Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added missing thumbnails for galleries #1982

Merged
merged 2 commits into from
Nov 8, 2024
Merged

Added missing thumbnails for galleries #1982

merged 2 commits into from
Nov 8, 2024
+9 −4

Conversation

oruebel
Copy link
Contributor

@oruebel oruebel commented Nov 7, 2024

Motivation

Fix #1980

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running ruff check . && codespell from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

@oruebel oruebel requested a review from stephprince November 7, 2024 22:02
@codecov Codecov
Copy link

codecov bot commented Nov 7, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.87%. Comparing base (e55de6c) to head (d39eb44).
Report is 1 commits behind head on dev.

Additional details and impacted files 
@@           Coverage Diff           @@
##              dev    #1982   +/-   ##
=======================================
  Coverage   91.87%   91.87%           
=======================================
  Files          27       27           
  Lines        2697     2697           
  Branches      704      704           
=======================================
  Hits         2478     2478           
  Misses        145      145           
  Partials       74       74
Flag Coverage Δ
integration 72.71% <ø> (ø)
unit 83.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

stephprince
stephprince approved these changes Nov 7, 2024
View reviewed changes
Copy link
Contributor

@stephprince stephprince left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I believe the Sphinx link check failures are unrelated and can be ignored for now.

@rly rly enabled auto-merge (squash) November 8, 2024 20:04
@rly rly merged commit 1bdffe8 into dev Nov 8, 2024
23 of 24 checks passed
@rly rly deleted the add/missing_tutorial_icons branch November 8, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephprince stephprince stephprince approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Documentation]: Missing thumbnails in the gallery
3 participants
@oruebel @stephprince @rly